Optical catalysts (photocatalyst) that there are in the group of catalysts which they became actived when exposed to light. The optical catalysts caused do or speed up chemical reactions In the light, while remain unchanged. One of the best candidates for the optical reactions is TiO 2 that can be used for treating pollutants with the photocatalytic reaction and Hydrogen Evalution Reaction (HER) with photoelectroreaction. Considering the fact that the band gap of TiO 2 is relatively large (3/2 eV), it is only active in the area of UV radiation, So can be doped some compounds on it to active in the visible light and optimal use of sunlight. In this study, by using the one- step anodizing WO 3 -TiO 2 nanotubes was produeced(0/012 M, tungestan to be optimized in the Before research.) The morphology, structure optical and photoelectrochemical propertise of these nanotubes were characterized by SEM , XRD, EDX , UV-Visible , LSV and choronoamprometry . These studies confirmed the formation of nanotubes,presence of tungsten and decrease in the band gap of TiO 2 of these compounds compared to TiO 2 and photoelectrocatalyst propertise of WO 3 -TiO 2 were best than TiO 2 nanotubes . In this research,Fe-Cr nanoparticles in various concentrations was doped on the nanotubes by ( CBD ) method and then the morphology, structure , optical and photoelectrochemical roperties of these nanotubes were characterized by SEM , XRD, EDX , UV-Visible, LSV and Choronoamprometry methods..results shown that these metals are present on the surface of the nanotubes and the band gap has been redused. Their photoelectrocatalytic properties for (HER) were studied.results showed that by metal doping, photoelectrocatalytic properties were improved And in the various concentrations , sample (CrFeWO 3 -TiO 2 1) due to better respond to the tests(HER) were chosen as the optimum sample. At the end of this study WO 3 -TiO 2 nanotubes were doped with Sn 0/1 M at different times and the morphology, structure, optical and photoelectrochemical properties of these nanotubes were characterized by SEM , XRD, EDAX , UV-Visible and LSv, Choronoamprometry methodes. These studies confirmed the presence tin on the surface of nanotubes and the band gap has been redused. Their photoelectrocatalytic properties for the (HER) were studied.results showed that by Sn doping, photoelectrocatalytic properties were improved And in the various times sample (SnWO 3 -TiO 2 2) due to better respond to the tests were chosen as the optimum sample.